Skip to content

Add uncertainties for main parameters.#299

Open
Sparks29032 wants to merge 5 commits into
diffpy:mainfrom
Sparks29032:covariance
Open

Add uncertainties for main parameters.#299
Sparks29032 wants to merge 5 commits into
diffpy:mainfrom
Sparks29032:covariance

Conversation

@Sparks29032
Copy link
Copy Markdown
Collaborator

@Sparks29032 Sparks29032 commented Apr 24, 2026

Closes #300

Need tests for warnings and each parameter separately (including baselineslope).

Need special handling for squeeze and func[x/y/xy] morph parameters.

image

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (fc45fa1) to head (5650feb).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          24       24           
  Lines        1480     1523   +43     
=======================================
+ Hits         1479     1522   +43     
  Misses          1        1           
Files with missing lines Coverage Δ
tests/test_morphapp.py 100.00% <ø> (ø)
tests/test_morphio.py 100.00% <100.00%> (ø)
tests/test_morphpy.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Sparks29032
Copy link
Copy Markdown
Collaborator Author

Sparks29032 commented May 11, 2026

Case where all parameters have uncertainties:
image

Case where certain parameters cause the Hessian to turn singular:
image

Tests and documentation updated. Ready to merge after review.

@Sparks29032
Copy link
Copy Markdown
Collaborator Author

Oops, previous one I ran only one of the tests I thought would be affected... fixed now.

@Sparks29032
Copy link
Copy Markdown
Collaborator Author

image

Loosened tolerance for checking numerics match. New algorithms and updates to old ones can cause some deviation (e.g. works on one of our tests on PR workflows but not others).

@Sparks29032 Sparks29032 marked this pull request as ready for review May 11, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to see uncertainties

1 participant