Acording to VS perf anylser, this reduces node.js update() from#106
Open
funinvegas wants to merge 1 commit intodigitalfruit:masterfrom
Open
Acording to VS perf anylser, this reduces node.js update() from#106funinvegas wants to merge 1 commit intodigitalfruit:masterfrom
funinvegas wants to merge 1 commit intodigitalfruit:masterfrom
Conversation
4.6% exclusive CPU to 1.9% exclusive CPU.
Commenting out the getUid() saved another 0.5%.
This change moves transition only code into a seperate function,
and only calls it if transitions are have been used on this node.
This saves several assignments and construction of inline {} object.
Contributor
Author
|
I commented out the getUID because it saved another 0.5% cpu and was initializing a variable that wasn't used later. |
Contributor
|
how do we know that these (micro) optimisations aren't breaking existing games ? |
|
If the data is correct, "4.6% exclusive CPU to 1.9% exclusive CPU, Commenting out the getUid() saved another 0.5%", then it is worth looking into it. Does the limejs team have any plan to do with this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4.6% exclusive CPU to 1.9% exclusive CPU.
Commenting out the getUid() saved another 0.5%.
This change moves transition only code into a seperate function,
and only calls it if transitions are have been used on this node.
This saves several assignments and construction of inline {} object.