Add a queue to shmrpc#2717
Open
Dreamsorcerer wants to merge 4 commits into
Open
Conversation
Contributor
Greptile SummaryThis PR adds a queued shared-memory path for RPC messages. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (4): Last reviewed commit: "Add assert" | Re-trigger Greptile |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #2717 +/- ##
==========================================
+ Coverage 72.35% 72.41% +0.05%
==========================================
Files 902 903 +1
Lines 81820 82064 +244
Branches 7396 7451 +55
==========================================
+ Hits 59201 59423 +222
- Misses 20639 20649 +10
- Partials 1980 1992 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if it might be more appropriate to use this everywhere for SHM or not. But, for RPC atleast, this fixes the concurrency tests.