never-merge: SimpleLidar — onboard L1 lidar re-expressed as the Mid-360#2721
Draft
jeff-hykin wants to merge 7 commits into
Draft
never-merge: SimpleLidar — onboard L1 lidar re-expressed as the Mid-360#2721jeff-hykin wants to merge 7 commits into
jeff-hykin wants to merge 7 commits into
Conversation
Pulls the Go2 WebRTC lidar (stamped world/odom-accumulated onboard), undoes the world transform back to base_link, and optionally applies a rigid transform (16-float 4x4) restamped to an output_frame so the cloud can pose as another sensor. un_accumulate subtracts the prior cloud in the world frame and publishes only new points, turning the accumulating stream into per-scan deltas.
Sibling to nav_3d that runs SimpleLidar with transform = inv(base_link->mid360_link) from the URDF, stamping the cloud mid360_link so the Go2 onboard lidar appears to originate from the Mid-360 frame. Promotes base_to_frame_matrix to public in mount_correction for reuse.
…eprint Replace the USE_ROTATED_MID360_MOUNT constant with two blueprints from a shared _nav_3d() factory: unitree-go2-nav-3d (normal mount) and unitree-go2-nav-3d-rotated (applies the mount_correction transform). Regenerate all_blueprints.py.
…imos into jeff/feat/kronk-nav-4-l1
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
SimpleLidar, a drop-inGO2Connectionsubclass that re-expresses the Go2's onboard L1 lidar in the Mid-360 frame (world→base_link un-transform, un-accumulated, then the staticbase_link→mid360_linkmount transform) so downstream stacks calibrated for the Mid-360 see the L1 cloud in the frame they expect. Wires it into theunitree-go2-l1-lidarandunitree-go2-mid360-record-combinedblueprints, splits the rotated mount into its own nav-3d variant, and promotesbase_to_frame_matrixplus aGO2Connection._publish_lidaroverride seam.Test plan
uv run pytest dimos/robot/test_all_blueprints_generation.pyplan_rrd.py) and confirm the L1 cloud lands inmid360_link