Skip to content

Fix tests to use password auth as md5#335

Draft
cpj2195 wants to merge 1 commit into
dimitri:mainfrom
cpj2195:cpj2195/fix_tests
Draft

Fix tests to use password auth as md5#335
cpj2195 wants to merge 1 commit into
dimitri:mainfrom
cpj2195:cpj2195/fix_tests

Conversation

@cpj2195

@cpj2195 cpj2195 commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@hanefi

hanefi commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

I do not see the value of this PR. Is there any harm in setting POSTGRES_HOST_AUTH_METHOD=trust in a test environment?

@dimitri

dimitri commented Oct 16, 2023

Copy link
Copy Markdown
Owner

I do not see the value of this PR. Is there any harm in setting POSTGRES_HOST_AUTH_METHOD=trust in a test environment?

I think the idea was that we used to have a problem with parsing connection strings longer than MAXCONNINFO, a static length provided by libpq, size 1024 bytes. We wanted to make sure that with some long authentication entries we would still be able to parse the connection string and connect. Meanwhile I believe we have fixed that issue, but making sure we're good on that front is a good idea.

That said we might be able to only change a couple of the unit test cases (with and without logical decoding) to have regression testing support in that area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants