Offload HTML parsing from RecyclerView bind to background + caching to reduce UI jank#5
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Html.fromHtml(...)calls inonBindViewHolderon heavy lists by moving expensive work off the main thread and reusing parsed results.PERFORMANCE_AUDIT.mdfor future optimizations and rollout tracking.Description
LruCache<String, Spanned>) toAdapterComments,AdapterForumPosts, andAdapterMainRazdeland introduced cache-key builders that includeid,text.hashCode()and font size viabuildHtmlCacheKey(...)or similar helper.ExecutorService htmlExecutorinAdapterComments/AdapterForumPostsand existingexecutorinAdapterMainRazdel, and use aHandler(Looper.getMainLooper())to safely post parsedSpannedresults back to the UI thread while validatingTextViewtags to avoid stale binds.AdapterMainRazdelusinginFlightHtmlKeysto avoid duplicate background tasks for the same HTML, and enabledsetHasStableIds(true)and stablegetItemId(...)to reduce unnecessary rebinding.onDetachedFromRecyclerView(...)andcleanup()where applicable, and updatedPERFORMANCE_AUDIT.mdwith iteration plan and status notes.Testing
./gradlew assembleDebugwhich completed successfully../gradlew testand they passed without failures../gradlew lint(static checks) and addressed no blocking issues; lint completed successfully.Codex Task