use C_Small/R_Small#720
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: US resistor symbol not updated to small variant
- Updated
stdlib/generics/Resistor.zenso theuse_us_symbolbranch now selectsR_Small_USinstead ofR_USfor symbol-size consistency.
- Updated
- ✅ Fixed: Test fixtures reference stale
Device:Rtarget symbol key- Updated the resistor promotion fixtures in
crates/pcb/src/import/generate.rsto useDevice:R_Small/R_Small_0_1so geometry lookup matches the new promoted target lib id.
- Updated the resistor promotion fixtures in
Or push these changes by commenting:
@cursor push e8ce129b05
Preview (e8ce129b05)
diff --git a/crates/pcb/src/import/generate.rs b/crates/pcb/src/import/generate.rs
--- a/crates/pcb/src/import/generate.rs
+++ b/crates/pcb/src/import/generate.rs
@@ -2861,9 +2861,9 @@
.to_string(),
),
(
- KiCadLibId::from("Device:R".to_string()),
- r#"(symbol "Device:R"
- (symbol "R_0_1"
+ KiCadLibId::from("Device:R_Small".to_string()),
+ r#"(symbol "Device:R_Small"
+ (symbol "R_Small_0_1"
(rectangle (start -1 -2) (end 3 4))
)
)"#
@@ -2933,9 +2933,9 @@
.to_string(),
),
(
- KiCadLibId::from("Device:R".to_string()),
- r#"(symbol "Device:R"
- (symbol "R_0_1"
+ KiCadLibId::from("Device:R_Small".to_string()),
+ r#"(symbol "Device:R_Small"
+ (symbol "R_Small_0_1"
(rectangle (start -1 -2) (end 3 4))
)
)"#
@@ -2974,9 +2974,9 @@
.to_string(),
),
(
- KiCadLibId::from("Device:R".to_string()),
- r#"(symbol "Device:R"
- (symbol "R_0_1"
+ KiCadLibId::from("Device:R_Small".to_string()),
+ r#"(symbol "Device:R_Small"
+ (symbol "R_Small_0_1"
(rectangle (start -1 -2) (end 3 4))
)
)"#
diff --git a/stdlib/generics/Resistor.zen b/stdlib/generics/Resistor.zen
--- a/stdlib/generics/Resistor.zen
+++ b/stdlib/generics/Resistor.zen
@@ -43,7 +43,7 @@
def _symbol(mount: Mount, package: Package, use_us_symbol: bool):
if use_us_symbol:
- name = "R_US"
+ name = "R_Small_US"
else:
name = "R_Small"You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit d037922. Configure here.
| @@ -45,7 +45,7 @@ def _symbol(mount: Mount, package: Package, use_us_symbol: bool): | |||
| if use_us_symbol: | |||
| name = "R_US" | |||
| else: | |||
| name = "R" | |||
| name = "R_Small" | |||
There was a problem hiding this comment.
US resistor symbol not updated to small variant
Medium Severity
The use_us_symbol branch still uses "R_US" instead of the small variant "R_Small_US" (which exists in KiCad's Device library). The non-US path was updated from "R" to "R_Small", but the US path was missed. This means users with use_us_symbol=True get a full-size symbol while everyone else gets a small one, creating an inconsistency.
Reviewed by Cursor Bugbot for commit d037922. Configure here.



Note
Low Risk
Symbol-only change for passives and import placement; netlist hashes shift but connectivity is unchanged.
Overview
Stdlib generic Resistor and Capacitor now use KiCad
R_SmallandC_Smallinstead ofR/C, which changes schematic appearance and netlist output (release snapshots updated).KiCad import promotion and
# pcb:schplacement math now targetDevice:R_Small/Device:C_Smallfor bbox and axis compensation; related unit tests were adjusted accordingly.Test sandbox: low-level
run_gitdisables global/system git config and interactive credential prompts so fixture git stays hermetic in CI.IPC-2581 HTML export: template/CSS
include_str!constants were moved above the test module (no behavior change).Reviewed by Cursor Bugbot for commit a5d54e6. Bugbot is set up for automated code reviews on this repo. Configure here.