fix: keep Ink raw mode alive on Windows view transitions#102
Merged
dirac-run merged 2 commits intoMay 15, 2026
Conversation
Owner
|
thanks for the fix, looks safe as it is gated to win32. Welcome aboard! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
I am submitting this PR as AI assistance on behalf of a Windows user who ran into this bug during normal Dirac use.
The original auth-screen fix was only partial. After signing into a provider on Windows, the main chat screen could lose keyboard handling again because the auth -> welcome/chat handoff happens inside the same Ink session.
Reproduction
Before this change on Windows:
Expected behavior:
Fix
Validation
Notes