Skip to content

feat: allow build secrets args to be passed in cli#21

Open
thpiron wants to merge 1 commit into
discourse:mainfrom
thpiron:feat/add_possibility_to_mount_build_secret
Open

feat: allow build secrets args to be passed in cli#21
thpiron wants to merge 1 commit into
discourse:mainfrom
thpiron:feat/add_possibility_to_mount_build_secret

Conversation

@thpiron
Copy link
Copy Markdown

@thpiron thpiron commented Apr 23, 2026

Add possibility to add secrets mount in docker build.

This is mainly to be able to fetch private dependency easily without secrets leaking in the docker image, but it could be useful for other hooks.

@featheredtoast
Copy link
Copy Markdown
Member

👋 hey @thpiron thanks for this - I'm open to the addition of secret args here. Current implementation doesn't use them at all as the initial implementation was translated from the bash script. Curious if it would make sense to pass some of the built in secrets as well, or are these build-time-only secrets (such as ssh keys to private repos) you're passing in?

The runtime secrets are a little complicated as quite often it's expected that those be baked into the final image, so that should continue to be an option.

Can you add some tests here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants