feat: allow build secrets args to be passed in cli#21
Open
thpiron wants to merge 1 commit into
Open
Conversation
Member
|
👋 hey @thpiron thanks for this - I'm open to the addition of secret args here. Current implementation doesn't use them at all as the initial implementation was translated from the bash script. Curious if it would make sense to pass some of the built in secrets as well, or are these build-time-only secrets (such as ssh keys to private repos) you're passing in? The runtime secrets are a little complicated as quite often it's expected that those be baked into the final image, so that should continue to be an option. Can you add some tests here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add possibility to add secrets mount in docker build.
This is mainly to be able to fetch private dependency easily without secrets leaking in the docker image, but it could be useful for other hooks.