Fix smithy4s-protobuf Scala.js dependency resolution#1916
Draft
kubukoz wants to merge 1 commit intoseries/0.18from
Draft
Fix smithy4s-protobuf Scala.js dependency resolution#1916kubukoz wants to merge 1 commit intoseries/0.18from
kubukoz wants to merge 1 commit intoseries/0.18from
Conversation
Use %%% instead of %% for scalapb-runtime in the non-JVM branch, so that the Scala.js artifact (scalapb-runtime_sjs1_3) is resolved instead of the JVM-only one (scalapb-runtime_3) which pulls in protobuf-java and breaks the Scala.js linker. Fixes #1915 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
something's up with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
%%%instead of%%forscalapb-runtimein the non-JVM protobuf dependency branch, so that the Scala.js artifact (scalapb-runtime_sjs1_3) is resolved instead of the JVM-only one (scalapb-runtime_3), which transitively pulls inprotobuf-javaand breaks the Scala.js linker.This was introduced in #1821 when the dependency was changed from
protobuf-runtime-scalatoscalapb-runtimebut the%%%operator was accidentally changed to%%.Before (broken — 0.18.51)
The published POM for
smithy4s-protobuf_sjs1_3depends on:scalapb-runtime_3(JVM only)protobuf-java(JVM only)lenses_3(JVM only)After (fixed)
The published POM depends on:
scalapb-runtime_sjs1_3(Scala.js compatible)Fixes #1915