Support parsing legacy BIP-174 PSBTs with zero inputs in embedded unsigned transactions - #117
Open
sinancrypto wants to merge 4 commits into
Open
Support parsing legacy BIP-174 PSBTs with zero inputs in embedded unsigned transactions#117sinancrypto wants to merge 4 commits into
sinancrypto wants to merge 4 commits into
Conversation
…edded unsigned tx with no inputs which has no flags
sinancrypto
changed the title
sinancrypto
changed the title
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of embit does not allow for parsing BIP-174 PSBTs with zerp input.
This fix enables support of parsing legacy BIP-174 PSBTs whose embedded unsigned transaction has zero inputs, without misinterpreting the leading 0x00 byte as a SegWit marker.
BIP 174 requires no flags for a PSBT which has no inputs (only having outputs).