Skip to content

Fix deploy workflow failing on no-op deploys #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djbender merged 1 commit into from
Apr 11, 2026
Merged

Fix deploy workflow failing on no-op deploys #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,4 +104,12 @@ jobs:
run: ssh-keyscan -p ${{ secrets.DOKKU_PORT }} -H ${{ secrets.DOKKU_HOST }} >> ~/.ssh/known_hosts

- name: Deploy to Dokku
run: ssh -p ${{ secrets.DOKKU_PORT }} dokku@${{ secrets.DOKKU_HOST }} git:from-image lizard ${{ env.IMAGE_NAME }}:${{ env.GIT_SHA_SHORT }}
run: |
output=$(ssh -p ${{ secrets.DOKKU_PORT }} dokku@${{ secrets.DOKKU_HOST }} git:from-image lizard ${{ env.IMAGE_NAME }}:${{ env.GIT_SHA_SHORT }} 2>&1) && exit 0
if echo "$output" | grep -q "No changes detected"; then
echo "No changes detected, skipping deploy"
exit 0
else
echo "$output"
exit 1
fi
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

### Fixed

- Deploy workflow failing when Dokku detects no image changes ("No changes detected, skipping git commit")
- CI gate job passing when dependent jobs fail (`success()` at step level doesn't check `needs` context)
- API key toggle not working (`td code { display: inline-block }` overrode `hidden` attribute)
- Full API key truncated when revealed (scoped `max-width`/`overflow` to truncated element only)
Expand Down