fix: Signer.notify classmethod, QueryBuilder em list_for_*, mypy strict e cobertura 88%#2
Merged
Merged
Conversation
- Adiciona bound_resource, transport, resource, client_scope e outros ao mypy strict - Usa `builtins.list` onde `list` shadowed pelo nome do método Resource.list - Corrige proxy_map em UrllibHTTPClient para não incluir key com proxy=None - Usa variável `raw: Any` para acessar atributos de exc httpx sem mypy error - Alinha assinaturas delete/retrieve com a base Resource (options=None) - Remove type: ignore redundantes após correções acima Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…id explícitos Instância podia não ter _parent_id definido, forçando fallback para rota sem envelope. Agora caller passa envelope_id e signer_id diretamente, eliminando dependência de estado interno da instância. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ra filtros
Substituí construção manual de {f"filter[{k}]": str(v)} por
QueryBuilder().filter(**filters).to_params() — consistente com o resto
do SDK e garante encoding correto de valores complexos.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adiciona casos para Signer.notify (classmethod), Requirement.list_for_*, Envelope.list_requirements com filtros, e fluxos de ClicksignClient / AsyncClient que não tinham cobertura. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…_api e types Novos arquivos cobrem BoundResource, AsyncBoundResource, HttpxHTTPClient, HttpxAsyncHTTPClient, http_executor, operações atômicas JSON:API e atributos de tipos TypedDict — áreas sem cobertura até agora. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- ruff format --check garante formatação consistente no pipeline - pytest --cov-fail-under=88 evita regressão de cobertura Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- CHANGELOG registra fixes de Signer.notify, QueryBuilder, tipos e CI - README reflete assinatura nova de Signer.notify - Guias (PAGINATION, TYPES, WORKFLOW, SDK_CONTRACT, etc.) alinhados com as mudanças de API desta branch - Adiciona docs/CONSIDERACOES.md e exemplo 13-async-fastapi.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Arquivo é backlog interno da equipe; .gitignore já o excluía mas não estava staged. Remove do índice git e commita a entrada no .gitignore. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
bound_resource,transport,resource,client_scopee recursos notariais; corrige anotações de tipo e proxy_map no urllib transportSigner.notifyvira classmethod — recebeenvelope_idesigner_idexplicitamente em vez de depender de_parent_idda instâncialist_for_document,list_for_signerelist_requirementsusamQueryBuilder().filter()em vez de construção manual defilter[k]paramsruff format --checke--cov-fail-under=88ao pipelinePlano de testes
Signer.notify(envelope_id, signer_id, message)funciona com nova assinaturaRequirement.list_for_document/list_for_signerpassam filtros corretamente🤖 Generated with Claude Code