Skip to content

Add "find_help_pages" function to search for help pages#485

Open
SyntaxError2505 wants to merge 8 commits into
dmtrKovalenko:mainfrom
SyntaxError2505:main
Open

Add "find_help_pages" function to search for help pages#485
SyntaxError2505 wants to merge 8 commits into
dmtrKovalenko:mainfrom
SyntaxError2505:main

Conversation

@SyntaxError2505
Copy link
Copy Markdown

I just copied the "find_files" function but made the directory be the file path of the documentation.

@dmtrKovalenko
Copy link
Copy Markdown
Owner

this is a good start, the one single problem is that it will reset the current index

I am happy to merge this in but I need to get back to this allowing ceratin "one-shot" created picker instance that is destroyed on close. I think this is valuable overall! Would you like to work on something like this

Also I think we should enforce modes to be { "Fuzzy" } by default becuase the directory is pretty small and fuzzy matching will just work better

@SyntaxError2505
Copy link
Copy Markdown
Author

Okay. I will fix the style errors and get to figuring that picker out. By fuzzy, do you mfn that live_grep like mode where you search for content or is there a function to search for filename?

@dmtrKovalenko
Copy link
Copy Markdown
Owner

The mode for content search

@SyntaxError2505
Copy link
Copy Markdown
Author

I got to a point where I am happy. It is just a hidden find_files call with opts being passed trough but the path being set to the doc directory. As a user, the only thing I could make better is hide the icons because every file inside is just text anyways.

@SyntaxError2505
Copy link
Copy Markdown
Author

at this point it could also just be a keybind on user side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants