fix(pi-fff): clarify tool prompt guidance#487
Open
themauveavenger wants to merge 1 commit into
Open
Conversation
Tune pi-fff prompt snippets and guidelines so Pi's flat tool guidance clearly names fffgrep, ffffind, and optional multi-grep tools. Also normalize @-mention path arguments and sync README tool docs with the current schemas and defaults. Validation: - bun test packages/pi-fff/test/query.test.ts - cd packages/pi-fff && bun run typecheck
Owner
|
thanks but I need to find some time to run our eval layer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The official pi documentation details how best to use
promptSnippetandpromptGuidelines. The three tools,ffgrep,fffind, andfff-multi-grephad these, but they weren't written in a way that an agent would be able to associate them with the actual tool. Specifically, each line inpromptGuidelinesshould be written as "Use my_tool when..." because they are separated from where the tool's name andpromptSnippetare loaded into the system prompt.The other change here is making it so that "@" doesn't end up as part of the query sent to
fff.Validation: