Skip to content

chore(Tooltip): add screenshot tests#4948

Merged
langz merged 2 commits intomainfrom
chore/add-existing-screenshot-tests-for-tooltip
Apr 11, 2025
Merged

chore(Tooltip): add screenshot tests#4948
langz merged 2 commits intomainfrom
chore/add-existing-screenshot-tests-for-tooltip

Conversation

@langz
Copy link
Copy Markdown
Contributor

@langz langz commented Apr 11, 2025

No description provided.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 6:16pm

langz
langz commented Apr 11, 2025
View reviewed changes
Comment thread packages/dnb-design-system-portal/src/docs/uilib/components/tooltip/Examples.tsx Outdated
scope={{ swissJoke }}
>
<Button
tooltip={swissJoke + ' ' + swissJoke + ' ' + swissJoke}
Copy link
Copy Markdown
Contributor Author

@langz langz Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using template literals, but that did not work 🤔
Got an error from gatsby 🎲

Copy link
Copy Markdown
Member

@tujoworker tujoworker Apr 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We should fix that issue here 😊

Copy link
Copy Markdown
Member

@tujoworker tujoworker Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an attempt to add support for back-ticks.

Copy link
Copy Markdown
Member

@tujoworker tujoworker Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a PR – let's test if the fix did work.

Copy link
Copy Markdown
Member

@tujoworker tujoworker Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in main now. So you may try it out 😵

Copy link
Copy Markdown
Contributor Author

@langz langz Apr 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems to be working now :)

91dfa3e

langz
langz commented Apr 11, 2025
View reviewed changes
Comment thread packages/dnb-design-system-portal/src/docs/uilib/components/tooltip/Examples.tsx Outdated
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Apr 11, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz langz force-pushed the chore/add-existing-screenshot-tests-for-tooltip branch from 1d98f7a to a4d761b Compare April 11, 2025 11:49
@langz langz force-pushed the chore/add-existing-screenshot-tests-for-tooltip branch from a4d761b to 11d7bb4 Compare April 11, 2025 12:05
@langz langz changed the title chore: add screenshot tests for existing tooltip functionality chore(Tooltip): add screenshot tests Apr 11, 2025
tujoworker
tujoworker approved these changes Apr 11, 2025
View reviewed changes
Comment thread packages/dnb-design-system-portal/src/docs/uilib/components/tooltip/Examples.tsx
import { Button, Tooltip, Span, NumberFormat } from '@dnb/eufemia/src'

const swissJoke =
'What’s the best thing about Switzerland? I’m not sure, but the flag is a big plus. 🇨🇭'
Copy link
Copy Markdown
Member

@tujoworker tujoworker Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha 🤣

@langz langz force-pushed the chore/add-existing-screenshot-tests-for-tooltip branch from 11d7bb4 to 91dfa3e Compare April 11, 2025 18:06
@langz
Copy link
Copy Markdown
Contributor Author

langz commented Apr 11, 2025

It could potentially be smart to merge this after we've merged/fixed #4951

@tujoworker
Copy link
Copy Markdown
Member

tujoworker commented Apr 11, 2025

ohh, I thought it would be good to merge it before, so we get confirmation that it works. But either way, you decide. Also, I hope you can collaborate on this PR, since @snorrekim is on 🌴

@langz
Copy link
Copy Markdown
Contributor Author

langz commented Apr 11, 2025

ohh, I thought it would be good to merge it before, so we get confirmation that it works. But either way, you decide. Also, I hope you can collaborate on this PR, since @snorrekim is on 🌴

Yeah, that's a valid point. Reason for me potentially wanting to wait, was just because it potentially would cause a bit of conflicts with that pr/contribution. But it's fine by me, either way.

@langz langz merged commit d1a203c into main Apr 11, 2025
10 checks passed
@langz langz deleted the chore/add-existing-screenshot-tests-for-tooltip branch April 11, 2025 19:24
@tujoworker
Copy link
Copy Markdown
Member

tujoworker commented Apr 15, 2025

🎉 This PR is included in version 10.71.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tujoworker tujoworker tujoworker approved these changes

Assignees

No one assigned

Labels

released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@langz @tujoworker