feat(operator): make the reconcile resync interval configurable - #32
Merged
Conversation
The controller's ResyncInterval was hardcoded to 30s, so operators could not tune how often every RedisFailover is periodically re-reconciled. Add a --resync-period duration flag (default 30s) plumbed through Config.ResyncPeriod; the factory falls back to the 30s default when it is left unset. Refs upstream spotahome#661.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
--resync-periodoperator flag (default30s) controlling how often everyRedisFailoveris periodically re-reconciled, in addition to reacting to change events.Why
The controller's
ResyncIntervalwas a hardcoded30sconstant. Operators had no way to trade periodic-healing latency against API load — a fixed 30s can be too chatty on large fleets or too slow when faster drift correction is wanted.Changes
config.go: newConfig.ResyncPeriod time.Duration.factory.go: usecfg.ResyncPeriod, falling back to the30sdefault when unset (safe for directNew()/test callers).cmd/utils/flags.go:--resync-periodduration flag wired into the config.Compatibility
Default is unchanged (
30s), so existing deployments behave identically.Upstream references
Test
go build ./...,go test ./...,gofmtclean.