feat(env): custom env vars on redis and sentinel main containers - #34
Merged
Conversation
Only the exporter sidecar accepted custom environment variables. Add an optional env field to the redis and sentinel specs, injected into their main containers. On the redis container the user's env is placed before the operator-injected vars (REDIS_ADDR/PORT/USER/PASSWORD) so those keep precedence under Kubernetes last-wins semantics. Regenerated CRD + deepcopy for the new fields. Refs upstream spotahome#290.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an optional
envfield ([]corev1.EnvVar) to theredisandsentinelspecs, injecting custom environment variables into their main containers. Previously only theexportersidecar accepted custom env.Why
Users need to pass environment variables (e.g. for wrapper scripts, TLS material paths, tuning) to the redis/sentinel processes. Implements the env portion of upstream spotahome#290. (The sysctl-init portion of that PR is already covered by the existing generic
initContainers.)Precedence
On the redis container the user's env is placed before the operator-injected vars (
REDIS_ADDR,REDIS_PORT,REDIS_USER,REDIS_PASSWORD). Under Kubernetes' last-wins semantics the operator vars therefore keep precedence and a user duplicate cannot override them. The sentinel main container has no operator-injected env, so the field is applied directly.Changes
api/.../types.go:RedisSettings.Env,SentinelSettings.Env.generator.go: wire into the redis STS + sentinel Deployment main containers.Upstream references
Test
go build ./...,go test ./...,gofmtclean; CRD regenerated via pinned codegen image.