fix rootless buildkit memory volume path#3858
Open
areebahmeddd wants to merge 2 commits into
Open
Conversation
Signed-off-by: Areeb Ahmed <areebahmed0709@gmail.com>
Collaborator
|
DCO is missing @areebahmeddd |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Kubernetes rootless BuildKit deployments so the buildkit-root-volume-memory option correctly applies to the rootless BuildKit data directory (/home/user/.local/share/buildkit) instead of the rootful path (/var/lib/buildkit), ensuring RAM-backed builds work as intended in rootless mode (closes #3422).
Changes:
- Pass
BuildKitRootVolumeMemoryinto the rootless pod template setup and apply it to the rootlessEmptyDirvolume. - Avoid creating/mounting the rootful
/var/lib/buildkitmemory volume when running in rootless mode. - Add unit tests covering rootless + memory, rootless without memory, and non-rootless + memory behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| driver/kubernetes/manifest/manifest.go | Applies memory-backed EmptyDir configuration to the rootless BuildKit data path and prevents rootful mounts in rootless mode. |
| driver/kubernetes/manifest/manifest_test.go | Adds tests validating the correct EmptyDir medium/sizeLimit and mount paths for rootless and non-rootless cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6c57932 to
1509ad3
Compare
Author
|
weird. i do use gpg signing automatically while committing but i force pushed my changes with the -s flag @thompson-shaun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
closes #3422
/home/user/.local/share/buildkitinstead of/var/lib/buildkit. thebuildkit-root-volume-memoryoption was using the wrong path, so builds still used the filesystem even when ram storage was enabled.ai model disclosure
used vscode copilot (claude sonnet 4.6) to understand the issue context and help generate a fix. changes were self-reviewed and verified via: