Skip to content

gha: add zizmor workflow#7024

Merged
thaJeztah merged 2 commits into
docker:masterfrom
thaJeztah:add_zizmor
Jun 3, 2026
Merged

gha: add zizmor workflow#7024
thaJeztah merged 2 commits into
docker:masterfrom
thaJeztah:add_zizmor

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Similar to moby/moby#52362, moby/buildkit#6623

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
name: zizmor

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include PR number (for PR flows) for reasons similar to docker/docs#25236 ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense in docker/docs#25236 because there is only a pull_request_target event but not here.

@thaJeztah thaJeztah requested review from crazy-max and vvoland June 3, 2026 10:08
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@crazy-max
Copy link
Copy Markdown
Member

Looks like we need to fix this one:

warning[template-injection]: code injection via template expansion
  --> ./.github/workflows/build.yml:81:24
   |
79 |         run: |
   |         --- this run block
80 |           mkdir /tmp/out
81 |           platform=${{ matrix.platform }}
   |                        ^^^^^^^^^^^^^^^ may expand into attacker-controllable code
   |

@thaJeztah
Copy link
Copy Markdown
Member Author

Interesting; why didn't it fail on that one?

@crazy-max
Copy link
Copy Markdown
Member

crazy-max commented Jun 3, 2026

Interesting; why didn't it fail on that one?

Because it's not new code and therefore not flagged in your PR, but you can see it in SARIF report: https://github.com/docker/cli/actions/runs/26877863807/job/79269874595#step:7:92

Also in code scanning:

vvoland
vvoland previously approved these changes Jun 3, 2026
@thaJeztah
Copy link
Copy Markdown
Member Author

Because it's not new code and therefore not flagged in your PR

Ah; is that configurable, or was that intentional (to not expose possible mis-configurations on a PR)?

@crazy-max
Copy link
Copy Markdown
Member

Because it's not new code and therefore not flagged in your PR

Ah; is that configurable, or was that intentional (to not expose possible mis-configurations on a PR)?

I don't think that is configurable

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

Pushed a commit with fixes from zizmor

@thaJeztah thaJeztah merged commit 37c3d31 into docker:master Jun 3, 2026
95 checks passed
@thaJeztah thaJeztah deleted the add_zizmor branch June 3, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants