Skip to content

fix: surface completed title responses#2372

Open
pandego wants to merge 1 commit intodocker:mainfrom
pandego:fix/2318-title-completed-output
Open

fix: surface completed title responses#2372
pandego wants to merge 1 commit intodocker:mainfrom
pandego:fix/2318-title-completed-output

Conversation

@pandego
Copy link
Copy Markdown
Contributor

@pandego pandego commented Apr 10, 2026

Summary

  • surface final message text from response.completed / response.done when the stream did not emit text deltas
  • preserve the existing finish-reason handling so title generation can succeed for GPT-5 responses that only include text in the terminal event
  • add websocket regression coverage for completed-response-only message output

Closes #2318

Testing

  • docker run --rm -v "$PWD":/src -w /src golang:1.26 go test ./pkg/model/provider/openai -run 'TestWSStream_(TextDelta|CompletedResponseIncludesFinalMessageText|ToolCall|EndToEnd_WithClient)' -count=1

Signed-off-by: pandego <7780875+pandego@users.noreply.github.com>
@pandego pandego requested a review from a team as a code owner April 10, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Title generation with gpt-5 fails

1 participant