agents: scope git hygiene hook to git add commands#25130
Open
stefanobaghino wants to merge 1 commit into
Open
Conversation
The `PreToolUse:Bash` hook invoked `enforce-git-hygiene.sh` on every Bash tool call, even though the script only blocks `git add . / -A / --all`. Add `"if": "Bash(git add *)"` so the script only runs when the command actually contains `git add`.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PreToolUse:Bashhook in.agents/settings.jsoninvokes.agents/hooks/enforce-git-hygiene.shon every Bash tool call, but the script's only job is to blockgit add . / -A / --all. Scope the hook with"if": "Bash(git add *)"so the script only runs when the command containsgit add. This removes per-tool-call overhead and noise — especially when an AI agent works across multiple projects in one session (e.g. via Claude Code's/add-dir), where this repo's hook isn't relevant to commands operating on the added directory.Verified empirically that
Bash(git add *)matchesgit addas a substring (covers compound forms likecd subdir && git add .), so the script's blocking coverage is unchanged.