ci: replace GHCR PAT in DinD test#1008
Merged
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
ci-ghcr-dind-test-image
branch
from
10ec1dc to
250c56f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the DinD CI test so it no longer depends on a long-lived GHCR PAT.
The workflow now builds and pushes a dummy GHCR image with
GITHUB_TOKEN, then the DinD job pulls that image withGITHUB_TOKENusing package read permissions.This keeps the test image inside the
docker/login-actionpackage scope and removes the dependency on the separatedocker-ghactiontest/testpackage and its PAT-based credentials.