Refuse long-lived server startup with missing secrets#499
Open
jstar0 wants to merge 1 commit into
Open
Conversation
Contributor
|
All checks pass and this generally looks good, but misssing some verified signatures on the PR :) |
bbc1d12 to
070949e
Compare
070949e to
8acef6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #433.
Long-lived local MCP server containers can keep running with placeholder secret values if they are started before required secrets are available. Once that container is cached, later calls can continue using the stale environment even after the user stores the real secret.
This change makes local long-lived Docker servers require verified required secrets before a client/container is created. If the secrets engine cannot be queried, fallback
se://URIs are not synthesized for those long-lived local servers, so missing secrets remain visible and the gateway returns a clear error instead of caching a container with a placeholder value.Changes
mcp-addvalidation attempts from enabling the server in memory.--long-lived, remote boundaries, and short-lived compatibility.Risk
This is scoped to required secrets for local long-lived Docker servers. It does not add secret-store watching or container recreation on secret changes, and it does not change short-lived or remote server startup behavior.
Verification