Close DBus connection after each Linux operation#544
Merged
Conversation
On Linux every keychain operation (Get/Save/Delete/GetAllMetadata/Filter) dials a fresh private session-bus connection via NewService -> dbus.ConnectSessionBus, but only closed the secret-service session, never the connection itself. Each call therefore leaked one socket file descriptor, and long-lived processes eventually exhausted the session bus's max_connections_per_user limit (failing with "maximum number of active connections has been reached"). Add SecretService.Close to release the connection and defer it in every operation. A regression test asserts the process's open-fd count stays flat across repeated lookups. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Remy Suen <remy.suen@docker.com>
Benehiko
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #542 with the tests removed.