chore: bump golangci-lint to v2.12.2#545
Merged
Merged
Conversation
Unify the two golangci-lint pins (Makefile v2.4.0 and Dockerfile ARG default v2.2.1) on v2.12.2. The newer gofumpt extra-rules flagged two naked returns in the vendored go-keychain corefoundation.go; apply the formatter's named-return fix so the lint stage stays green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This is a clean, low-risk tooling bump:
- Dockerfile and Makefile: version pins unified to
v2.12.2(previouslyv2.2.1andv2.4.0respectively) - corefoundation.go: two naked
returnstatements replaced with explicitreturn m/return a— semantically identical, satisfying the stricter gofumpt rules in the new linter version
No logic errors, security issues, resource leaks, or behavioral changes were introduced.
joe0BAB
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify the two golangci-lint pins (Makefile v2.4.0 and Dockerfile ARG default v2.2.1) on v2.12.2. The newer gofumpt extra-rules flagged two naked returns in the vendored go-keychain corefoundation.go; apply the formatter's named-return fix so the lint stage stays green.