ci: fall back to local buildx builder for fork PRs#550
Merged
Conversation
Fork pull requests don't receive repository secrets, so the docker/login-action step failed with "Password required" and the Docker Build Cloud builder (driver: cloud, endpoint: docker/secrets-engine) was unreachable. This failed every lint/build/proto/vuln job and the Linux keychain tests for external contributions. Gate the Hub login on trusted events and switch the buildx driver to a local docker-container builder for fork PRs, keeping cloud builds for pushes, tags, and same-repo PRs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
govulncheck flagged two standard-library vulnerabilities reachable from our code across the plugin, credentialhelper, pass, and x modules: - GO-2026-5039: unescaped arbitrary input in net/textproto errors - GO-2026-5037: inefficient candidate hostname parsing in crypto/x509 Both are fixed in go1.25.11. Bump the go directive in go.work and every module's go.mod (the Docker build derives GO_VERSION from go.work), and refresh vendor/modules.txt via `go work vendor`. govulncheck now reports zero affected vulnerabilities across all modules. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork pull requests don't receive repository secrets, so the docker/login-action step failed with "Password required" and the Docker Build Cloud builder (driver: cloud, endpoint: docker/secrets-engine) was unreachable. This failed every lint/build/proto/vuln job and the Linux keychain tests for external contributions.
Gate the Hub login on trusted events and switch the buildx driver to a local docker-container builder for fork PRs, keeping cloud builds for pushes, tags, and same-repo PRs.