Run agent-browser install as coder user in Docker#4
Merged
Conversation
The agent-browser install (which downloads Chromium) was only run as root. Adding a second install after USER coder ensures Chromium is available in the coder user's home directory at runtime. https://claude.ai/code/session_01MukmmJhsNvpwRmVAqAQvd8
Use `runuser -u coder -- agent-browser install` in the root RUN block so Chromium is installed into the coder user's home directory in-place, instead of a separate RUN layer after USER coder. https://claude.ai/code/session_01MukmmJhsNvpwRmVAqAQvd8
Add claude/** branches to push trigger so the test job runs on feature branch pushes. Docker Hub push remains gated to master only. https://claude.ai/code/session_01MukmmJhsNvpwRmVAqAQvd8
Remove branches filter from push trigger so the test job runs on pushes to any branch. Docker Hub push remains gated to master only. https://claude.ai/code/session_01MukmmJhsNvpwRmVAqAQvd8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified the Docker build process to execute the
agent-browser installcommand as thecoderuser instead of the root user.Key Changes
agent-browser installtorunuser -u coder -- agent-browser installin the DockerfileImplementation Details
The change uses
runuserto switch to thecoderuser context before executing the installation command. This is a security and permission best practice that ensures the agent-browser package is installed with the correct user ownership and permissions, preventing potential permission issues when the container runs as thecoderuser.https://claude.ai/code/session_01MukmmJhsNvpwRmVAqAQvd8