feat: add DOCLINGCORE_ALLOWED_PRIVATE_IPS setting to allow private IPs#608
Open
COTHSC wants to merge 1 commit into
Open
feat: add DOCLINGCORE_ALLOWED_PRIVATE_IPS setting to allow private IPs#608COTHSC wants to merge 1 commit into
COTHSC wants to merge 1 commit into
Conversation
… access Signed-off-by: COTHSC <thierryscully.colomban@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @COTHSC, all your commits are properly signed off. 🎉 |
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #599
Adds an optional "allowed_private_ips" to CoreSettings to specify safe internal IPs as described in the issue
Default behaviour is unchanged