You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
remove the ref attachment from ScrollViewGesture's GestureDetector child to avoid triggering React 19 element.ref access warnings on web paths
replace measure(containerRef) boundary calculation with layout.containerSize from store (already updated by onLayout)
add a regression test that fails when Accessing element.ref was removed in React 19 is emitted
Why
Issue #857 reports React 19 web warning: Accessing element.ref was removed in React 19
The upstream warning is triggered when a dependency reads element.ref; passing a child ref through this path made the warning visible in carousel usage.
Tests
yarn test src/components/ScrollViewGesture.test.tsx --runInBand
yarn test src/components/Carousel.test.tsx --runInBand
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.10%. Comparing base (5289d9d) to head (6bf7e67). ⚠️ Report is 2 commits behind head on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refattachment fromScrollViewGesture'sGestureDetectorchild to avoid triggering React 19element.refaccess warnings on web pathsmeasure(containerRef)boundary calculation withlayout.containerSizefrom store (already updated byonLayout)Accessing element.ref was removed in React 19is emittedWhy
Issue #857 reports React 19 web warning:
Accessing element.ref was removed in React 19The upstream warning is triggered when a dependency reads
element.ref; passing a childrefthrough this path made the warning visible in carousel usage.Tests
yarn test src/components/ScrollViewGesture.test.tsx --runInBandyarn test src/components/Carousel.test.tsx --runInBandyarn biome check src/components/ScrollViewGesture.tsx src/components/ScrollViewGesture.test.tsxFixes #857