Skip to content

zako matches ftcoattack100#2666

Merged
jurrejelle merged 5 commits into
doldecomp:masterfrom
jurrejelle:jj/co100
Jun 12, 2026
Merged

zako matches ftcoattack100#2666
jurrejelle merged 5 commits into
doldecomp:masterfrom
jurrejelle:jj/co100

Conversation

@jurrejelle

Copy link
Copy Markdown
Collaborator

Ported from stephenjayakar:pr-15 (#2238), reworked to avoid the regressions to fn_800DAA40 and fn_800DAD18 that branch had:

  • fn_800D7938: drop the function-pointer cast on it_80291F14
  • fn_800DBBF8: keep fn_800DAA40 out of line via dont_inline, using direct user_data access and ftCo_804D90C8 so fn_800DAA40 itself still matches
  • ftCo_CaptureWaitLw_Phys: keep fn_800DAD18 out of line via a noinline wrapper defined before the callee

Ported from stephenjayakar:pr-15 (doldecomp#2238), reworked to avoid the
regressions to fn_800DAA40 and fn_800DAD18 that branch had:

- fn_800D7938: drop the function-pointer cast on it_80291F14
- fn_800DBBF8: keep fn_800DAA40 out of line via dont_inline, using
  direct user_data access and ftCo_804D90C8 so fn_800DAA40 itself
  still matches
- ftCo_CaptureWaitLw_Phys: keep fn_800DAD18 out of line via a
  noinline wrapper defined before the callee

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@decomp-dev

decomp-dev Bot commented Jun 12, 2026

Copy link
Copy Markdown

Report for GALE01 (500a946 - 2851667)

📈 Matched code: 72.50% (+0.04%, +1592 bytes)

✅ 4 new matches
Unit Item Bytes Before After
main/melee/ft/chara/ftCommon/ftCo_Attack100 fn_800DBBF8 +186 33.73% 100.00%
main/melee/ft/chara/ftCommon/ftCo_Attack100 ftCo_CaptureWaitLw_Phys +169 49.25% 100.00%
main/melee/ft/chara/ftCommon/ftCo_Attack100 fn_800D7938 +21 82.24% 100.00%
main/melee/ft/chara/ftCommon/ftCo_Attack100 fn_800D8EC8 +1 99.99% 100.00%

@jurrejelle jurrejelle marked this pull request as ready for review June 12, 2026 18:33
@jurrejelle jurrejelle enabled auto-merge (squash) June 12, 2026 18:33
@jurrejelle jurrejelle mentioned this pull request Jun 12, 2026
@jurrejelle jurrejelle merged commit 3c8c9c0 into doldecomp:master Jun 12, 2026
8 checks passed
kolt-mcb pushed a commit to kolt-mcb/melee that referenced this pull request Jun 13, 2026
* Match fn_800D7938, fn_800DBBF8 and ftCo_CaptureWaitLw_Phys

Ported from stephenjayakar:pr-15 (doldecomp#2238), reworked to avoid the
regressions to fn_800DAA40 and fn_800DAD18 that branch had:

- fn_800D7938: drop the function-pointer cast on it_80291F14
- fn_800DBBF8: keep fn_800DAA40 out of line via dont_inline, using
  direct user_data access and ftCo_804D90C8 so fn_800DAA40 itself
  still matches
- ftCo_CaptureWaitLw_Phys: keep fn_800DAD18 out of line via a
  noinline wrapper defined before the callee

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* cleanup fn_800DAA40

* 100% of fn_800D8EC8

* 100% of fn_800DBBF8

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant