Repository navigation
Prepare the website for twenty more languages - #85
Conversation
The site generator already treated a language as a file per page and a key per word. This
adds what a larger set needs and keeps the rule that a half-finished language fails the build.
- A language registry in site.json: tag, og:locale, the language's own name, the short code the
switch shows, direction and slug policy. A language can be in the registry and not published.
- The language switch is a disclosure listing every language by its own name, with no script.
- Slugs are either the language's own or the default language's, so the alphabets that cannot be
an ASCII address are not transliterated into one.
- {{url:ID}} resolves another page's address in the language of the page that writes it.
- A translation is held against its original: same block structure, same links to the same
pages, same commands (comments and angle-bracket placeholders excepted), same tokens.
- A translation records which English it follows. An older one is listed, and fails the build
only with --require-fresh. --stamp CODE records it, and a missing stamp is always a problem.
- Right to left: logical properties instead of left and right, code isolated from the page
direction, no letter spacing in cursive or CJK scripts, a font stack and line height per script.
- The Polish code samples go back to the English commands so one check covers every language,
and the question about the program's own language is now in the English source too.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Desktop Robustness |  |
The new --stamp feature writes repository data files non-atomically. Freshness.StampPage and Freshness.StampWords call File.WriteAllText directly at site/Bws.Site/Freshness.cs:222 and :248… |
Write each updated file to a temporary file in the same directory, flush and close it, then replace the target with an atomic same-volume rename. Delete the temporary file on failure. Validate the existing HTML/JSON before changing it, and … |
| Safe File Parsing | |
The PR introduces unsafe file-derived output and parsing. site/site.json supplies LanguageInfo.Locale, but Renderer.AppendOpenGraph writes it directly into HTML attributes at Renderer.cs:123 a… |
Escape every registry value at its output boundary, especially with Html.Escape(info.Locale), and validate locale syntax with a strict allowlist. Replace JsonStampLine.Replace and string insertion with JsonNode.Parse or JsonDocument… |
| Clear User-Facing Text | |
The new language disclosure shows only EN or PL, but its tooltip is set to the generic label Language or Język (Renderer.cs:243). This tooltip does not identify the selected language or expl… |
Set the summary tooltip to the same informative text as its accessible label, for example title="Language: English" or the localized equivalent title="Język: Polski". A localized Change language (current: ...) label is also suitable. |
| Scope, Duplication And Docs | |
The PR adds undocumented website-generator CLI arguments and changes the site configuration format. site/Bws.Site/Program.cs adds --require-fresh and --stamp CODE, but no README, CHANGELOG, or o… |
Add developer documentation for bws-site --require-fresh, --stamp, freshness stamps, and the language_registry schema. Update the CHANGELOG if this generator is a supported CLI. Add a Breaking changes section that states the old `site… |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title accurately describes the pull request's main change: adding website infrastructure to support twenty additional languages. It is specific and suitable for release notes or git history. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Tests For Changed Behavior The PR adds site-generator runtime behavior and updates tests/Bws.Site.Tests/GeneratorTests.cswith coverage for translation parity, freshness and stamping, line-ending normalization, language regis…No Secrets Or Debug Leftovers The pull request adds no CLAUDE.md, CLAUDE.local.md, AGENTS.md, .claude, or .env files. The added content contains no credentials, API keys, personal emails, internal hosts/IPs, or local absolute path… No Hardcoded Ui Styling The pull request does not add or change XAML, Slint, Fyne, Tkinter, or WPF code-behind. It changes website HTML and a shared CSS stylesheet. The new website styles use shared CSS variables and shared … No Obvious Performance Problems No clear performance problem is introduced. The new translation checks process each published page-language pair once with bounded regexes and linear collection comparisons. Freshness checks perform b… System Changes Are Reversible The authoritative PR diff changes a static-site generator, website content, CSS, and tests. The generator writes site output and optional translation stamps, but it does not modify network filters, pr… No Resource Leaks No resource leak is introduced. The PR adds static site-generation checks and bounded in-memory lists. File.ReadAllText/File.WriteAllText and directory enumeration use framework-managed operations. Th… Full details: Tests For Changed Behavior
-
Explanation
The PR adds site-generator runtime behavior and updates
tests/Bws.Site.Tests/GeneratorTests.cswith coverage for translation parity, freshness and stamping, line-ending normalization, language registry validation, slug rules, RTL rendering and language switching, and URL-token resolution. The mutation registry links these new tests to the changed runtime files. Existing test methods remain; no skip markers or weakened behavioral assertions were introduced. The language-count assertion was generalized to readsite.json, and the ASCII guard was intentionally updated for native-script localization files.
Full details: No Secrets Or Debug Leftovers
-
Explanation
The pull request adds no CLAUDE.md, CLAUDE.local.md, AGENTS.md, .claude, or .env files. The added content contains no credentials, API keys, personal emails, internal hosts/IPs, or local absolute paths. The URLs are public project/test URLs. Console.WriteLine calls are normal CLI status output, not debug leftovers.
Full details: No Hardcoded Ui Styling
-
Explanation
The pull request does not add or change XAML, Slint, Fyne, Tkinter, or WPF code-behind. It changes website HTML and a shared CSS stylesheet. The new website styles use shared CSS variables and shared selectors, so the stated GUI hardcoding condition does not apply.
Full details: No Obvious Performance Problems
-
Explanation
No clear performance problem is introduced. The new translation checks process each published page-language pair once with bounded regexes and linear collection comparisons. Freshness checks perform bounded file reads and hashes for the static site. The language switch contains 22 registry entries, which is not a large unvirtualized collection. The generated site has no scripts or timers that could block or poll the UI.
Full details: System Changes Are Reversible
-
Explanation
The authoritative PR diff changes a static-site generator, website content, CSS, and tests. The generator writes site output and optional translation stamps, but it does not modify network filters, proxies, firewalls, system time, process hooks or injection, Windows services, the registry, or drivers. The reversibility requirements do not apply.
Full details: No Resource Leaks
-
Explanation
No resource leak is introduced. The PR adds static site-generation checks and bounded in-memory lists. File.ReadAllText/File.WriteAllText and directory enumeration use framework-managed operations. The added JsonDocument is disposed with using at tests/Bws.Site.Tests/GeneratorTests.cs:59. Test temporary directories are deleted in Dispose at GeneratorTests.cs:33-38. No timers, subscriptions, processes, streams, native handles, or uncancelled tasks are added.
-
Full details: Desktop Robustness
-
Explanation
The new
--stampfeature writes repository data files non-atomically.Freshness.StampPageandFreshness.StampWordscallFile.WriteAllTextdirectly atsite/Bws.Site/Freshness.cs:222and:248, after reading and rewriting translation HTML and JSON files. A write interruption can leave a partially written file. The pull request introduces these methods; the base version had noFreshness.csor stamp writes.Resolution
Write each updated file to a temporary file in the same directory, flush and close it, then replace the target with an atomic same-volume rename. Delete the temporary file on failure. Validate the existing HTML/JSON before changing it, and report missing or malformed input as a build problem instead of rewriting or propagating corrupted data.
Full details: Safe File Parsing
-
Explanation
The PR introduces unsafe file-derived output and parsing.
site/site.jsonsuppliesLanguageInfo.Locale, butRenderer.AppendOpenGraphwrites it directly into HTML attributes atRenderer.cs:123and126;SiteConfig.Validateonly checks that it is non-empty. A quote in the JSON can break the attribute and inject markup. The newParityregexes run with timeouts, butProgram.cs:111does not catchRegexMatchTimeoutException, so malformed or very large translation HTML can terminate the generator. The newFreshness.StampWordsusesJsonStampLine.Replaceand string slicing atFreshness.cs:233-240instead of parsing JSON, so malformed input or a matching text fragment inside a JSON string can produce corrupted JSON.Resolution
Escape every registry value at its output boundary, especially with
Html.Escape(info.Locale), and validate locale syntax with a strict allowlist. ReplaceJsonStampLine.Replaceand string insertion withJsonNode.ParseorJsonDocumentplus a structured JSON writer; reject malformed or non-object input before writing. Bound input size beforeReadAllText, and catchRegexMatchTimeoutExceptionto report a build problem, or replace the regex HTML scan with a bounded parser.
Full details: Clear User-Facing Text
-
Explanation
The new language disclosure shows only
ENorPL, but its tooltip is set to the generic labelLanguageorJęzyk(Renderer.cs:243). This tooltip does not identify the selected language or explain the control. The accessible label has the useful text (Language: English), but sighted mouse users do not receive it.Resolution
Set the summary tooltip to the same informative text as its accessible label, for example
title="Language: English"or the localized equivalenttitle="Język: Polski". A localizedChange language (current: ...)label is also suitable.
Full details: Scope, Duplication And Docs
-
Explanation
The PR adds undocumented website-generator CLI arguments and changes the site configuration format.
site/Bws.Site/Program.csadds--require-freshand--stamp CODE, but no README, CHANGELOG, or other developer documentation changed.site/site.jsonadds the requiredlanguage_registry, andSiteConfignow deserializes it directly; the PR description has no Breaking changes section or migration/fallback for older configuration files. The feature scope itself is described, and the new localization code does not duplicate an existing base mechanism.Resolution
Add developer documentation for
bws-site --require-fresh,--stamp, freshness stamps, and thelanguage_registryschema. Update the CHANGELOG if this generator is a supported CLI. Add a Breaking changes section that states the oldsite.jsonformat is incompatible, and provide a migration or backward-compatible default for configurations withoutlanguage_registry.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
coderabbitai
Bot
added
bug
The tests edited the published list by matching its exact text and borrowed Arabic for the right-to-left case, so each language added would have broken them. They now append to whatever the list holds and invent the languages they need. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…uctured data French writes a no-break space before a colon and a question mark, as an entity. The structured data is JSON a machine reads, and without this it carried the letters of the entity. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A label is nowrap so a short English one stays on a line, but a label of forty-odd characters in another language is wider than a phone and pushed the whole page sideways - Spanish at 375 px, six pixels over. The button is full width there already, so wrapping costs a line of height. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The tests for the languages took GeneratorTests over the ceiling the size ratchet holds test files to. The seam is the one the file already had: the sandbox a test breaks something in, the older tests, and the tests for languages. The mutation entries follow the tests that moved. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
What this changes
The generator already had one file per page per language and one key per word. This adds what twenty-two languages need. No new language is published by this PR -
languagesstays["en", "pl"]. The other twenty are written and enabled in later PRs, a handful at a time.site/site.json: tag,og:locale, the language's own name, the short code the switch shows, direction, slug policy. A language can be registered and not yet published.<details>disclosure listing every language by its own name. No script, which the site promises.{{url:ID}}resolves another page's address in the language of the page that writes it.<placeholder>words excepted), same tokens.--require-fresh.--stamp CODErecords it. A missing stamp is always a problem.style.css: logical properties, code isolated from the page direction, no letter spacing in cursive or CJK text, a font stack and line height per script.Checked
--require-fresh.Bws.Site.Tests: 40 passing.PublicSurfaceGuardsandSizeRatchetGuardspassing.stale-check: 0.Not checked
diron the English page, not on Arabic text.🤖 Generated with Claude Code