fix: org-roam-node-insert - prevent extra space added in visual mode#8621
Open
russmatney wants to merge 1 commit into
Open
fix: org-roam-node-insert - prevent extra space added in visual mode#8621russmatney wants to merge 1 commit into
russmatney wants to merge 1 commit into
Conversation
…isual mode I like to visually select text, then org-roam-node-insert. This has been broken for my usage for a while, finally tracked it down today. The fix from doomemacs#8513 causes an extra space to be added on every visual-mode org-roam-node-insert, so this just adds another guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like to visually select text, then org-roam-node-insert. This has been broken for my usage for a while, finally tracked it down today.
The fix from #8513 causes an extra space to be added on every visual-mode org-roam-node-insert, so this commit just adds another guard.
I was a bit lazy and committed this via github's UI before reading the commit standards. sorry! happy to rewrite/amend it if you prefer. Or feel free to make the change elsewhere and close this PR 🤷Updated the commit to hopefully fit the standard better!Thanks for maintaining Doom! It's been excellent for many years!!