fix(vterm): buffer read-only error after compiling#8623
Open
AjaiKN wants to merge 1 commit into
Open
Conversation
If libvterm hasn't been compiled yet when vterm first loads, it'll offer to compile it for you. If you say yes, then vterm will switch to the compilation buffer. If vterm was autoloaded from a vterm-mode call, this is a problem: by the time the vterm-mode function runs, the current buffer will be the compilation buffer. The vterm-mode call will fail because the compilation buffer is read-only. Instead, we can explicitly require vterm before with-current-buffer so it's already loaded before we call vterm-mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first time I run
+vterm/toggle, if I say yes to vterm's offer to compile libvterm for me, then after it compiles successfully, I get this error:vterm-mode: Buffer is read-only: #<buffer *Install vterm* >. That's because when vterm is autoloaded, it changes the current buffer to the compilation buffer, which is read-only. If I actually want a vterm buffer, I need to run+vterm/togglea second time.Instead, we can explicitly require vterm before
with-current-bufferso it's already loaded before we callvterm-mode.