-
Notifications
You must be signed in to change notification settings - Fork 330
Test | Convert DateTimeVariantTests to xunit #4196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
abf9d91
Remove flaky trait and culture workaround from DateTimeVariantTests
mdaigle 06bfa1e
Split the DateTimeVariant baseline file into individual test cases.
mdaigle 9bf93db
Make DateTimeVariant tests parameterized
mdaigle 127a013
Restructure error handling in DateTimeVariant helper
mdaigle 76d27c4
Introduce TestVariations enum and associate exceptions with test cases
mdaigle 2584ba4
Refactor helper signatures and pull value/type overrides to parameters
mdaigle 7e5b988
Replace console logs with xunit assertions
mdaigle 5367fb1
Remove empty baseline files and csproj references
mdaigle df6468e
Clean up unused code and consolidate exception checkers
mdaigle 499452b
Consolidate DateTimeVariantTest.cs into DateTimeVariantTests.cs
mdaigle deaa4ff
Set en-US culture in RunTest to fix Linux test failures
mdaigle 8a65c9d
Merge branch 'main' of github.com:dotnet/SqlClient into dev/mdaigle/d…
mdaigle 53994ca
Use RAII types. Update testing instructions.
mdaigle fb9b17c
Mark tests as flaky, this was accidentally removed.
mdaigle 9688288
Addressed copilot comments.
mdaigle 0284135
Clean up DisposableArray.Dispose()
mdaigle 446fd7d
Merge branch 'dev/mdaigle/datetime-xunit' of https://github.com/dotne…
mdaigle cfd497a
Address copilot comments.
mdaigle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.