Skip to content

Remove unused action inputs for preview link generator - #704

Merged
gewarren merged 1 commit into
dotnet:mainfrom
gewarren:preview-link-inputs
Jul 27, 2026
Merged

Remove unused action inputs for preview link generator#704
gewarren merged 1 commit into
dotnet:mainfrom
gewarren:preview-link-inputs

Conversation

@gewarren

Copy link
Copy Markdown
Collaborator

Inputs no longer needed since links are pulled as-is from build report instead of constructed using bits and pieces.

Copilot AI review requested due to automatic review settings July 27, 2026 19:45
@gewarren
gewarren requested a review from a team as a code owner July 27, 2026 19:45
@gewarren
gewarren enabled auto-merge (squash) July 27, 2026 19:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused GitHub Action inputs from the preview-link-generator action now that preview links are extracted directly from the OpenPublishing build report rather than assembled from configurable path segments.

Changes:

  • Removed the docs_path, url_base_path, and opaque_leading_url_segments inputs from the action definition.
  • Removed the corresponding WorkflowInput accessors from the TypeScript source and the compiled dist/index.js.
  • Updated unit tests to assert the remaining inputs (repo_token, collapsible_after, max_row_count).

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
actions/preview-link-generator/src/types/WorkflowInput.ts Drops unused input getters so runtime config matches the new “pull links as-is from report” behavior.
actions/preview-link-generator/dist/index.js Updates the compiled action bundle to remove the same unused input handling.
actions/preview-link-generator/action.yml Removes no-longer-supported inputs from the public action interface.
actions/preview-link-generator/tests/pull-updater.test.ts Updates tests to validate only the remaining supported inputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adegeo
adegeo disabled auto-merge July 27, 2026 21:22

@adegeo adegeo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and disabled auto merge to double check. Are you sure about this? I know those items were added to support the docs-desktop repo.

@gewarren

Copy link
Copy Markdown
Collaborator Author

Approved and disabled auto merge to double check. Are you sure about this? I know those items were added to support the docs-desktop repo.

Yeah, those are only needed if you're manually constructing the review.learn.microsoft.com links.

@gewarren
gewarren merged commit 455480c into dotnet:main Jul 27, 2026
9 checks passed
@gewarren
gewarren deleted the preview-link-inputs branch July 27, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants