Remove unused action inputs for preview link generator - #704
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes unused GitHub Action inputs from the preview-link-generator action now that preview links are extracted directly from the OpenPublishing build report rather than assembled from configurable path segments.
Changes:
- Removed the
docs_path,url_base_path, andopaque_leading_url_segmentsinputs from the action definition. - Removed the corresponding
WorkflowInputaccessors from the TypeScript source and the compileddist/index.js. - Updated unit tests to assert the remaining inputs (
repo_token,collapsible_after,max_row_count).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| actions/preview-link-generator/src/types/WorkflowInput.ts | Drops unused input getters so runtime config matches the new “pull links as-is from report” behavior. |
| actions/preview-link-generator/dist/index.js | Updates the compiled action bundle to remove the same unused input handling. |
| actions/preview-link-generator/action.yml | Removes no-longer-supported inputs from the public action interface. |
| actions/preview-link-generator/tests/pull-updater.test.ts | Updates tests to validate only the remaining supported inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adegeo
left a comment
There was a problem hiding this comment.
Approved and disabled auto merge to double check. Are you sure about this? I know those items were added to support the docs-desktop repo.
Yeah, those are only needed if you're manually constructing the review.learn.microsoft.com links. |
Inputs no longer needed since links are pulled as-is from build report instead of constructed using bits and pieces.