Skip to content

fix #34001: NULL handling in search condition CASE/WHEN #38146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pumpkin-bit wants to merge 1 commit into from
+6 −4
Closed

fix #34001: NULL handling in search condition CASE/WHEN #38146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/EFCore.SqlServer/Query/Internal/SearchConditionConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,17 @@ private SqlExpression ApplyConversion(SqlExpression sqlExpression, bool inSearch
: sqlExpressionFactory.Equal(sqlExpression, sqlExpressionFactory.Constant(true)),

// A search condition expression in non-search condition context - wrap in CASE/WHEN to convert to bit:
// e.g. SELECT a LIKE b => SELECT CASE WHEN a LIKE b THEN 1 ELSE 0 END
// TODO: NULL is not handled properly here, see #34001
// e.g. SELECT a LIKE b => SELECT CASE WHEN a LIKE b THEN 1 WHEN NOT (a LIKE b) THEN 0 ELSE NULL END
(false, true) => sqlExpressionFactory.Case(
[
new CaseWhenClause(
SimplifyNegatedBinary(sqlExpression),
sqlExpressionFactory.ApplyDefaultTypeMapping(sqlExpressionFactory.Constant(true)))
sqlExpressionFactory.ApplyDefaultTypeMapping(sqlExpressionFactory.Constant(true))),
new CaseWhenClause(
SimplifyNegatedBinary(sqlExpressionFactory.Not(sqlExpression)),
sqlExpressionFactory.ApplyDefaultTypeMapping(sqlExpressionFactory.Constant(false)))
],
sqlExpressionFactory.Constant(false)),
sqlExpressionFactory.Constant(null, sqlExpression.Type, sqlExpression.TypeMapping)),

// All other cases (e.g. WHERE a LIKE b, SELECT b.SomebitColumn) - no need to do anything.
_ => sqlExpression
Expand Down
Loading