Consolidate unix platforms flavors in S.N.Http#129926
Open
am11 wants to merge 5 commits into
Open
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
am11
force-pushed
the
feature/system.net.http/consolidate-unix
branch
from
55d944f to
f346587
Compare
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
am11
force-pushed
the
feature/system.net.http/consolidate-unix
branch
2 times, most recently
from
4f81283 to
62ba83e
Compare
am11
force-pushed
the
feature/system.net.http/consolidate-unix
branch
from
62ba83e to
a9cc79e
Compare
am11
commented
Jun 27, 2026
jkotas
reviewed
Jun 28, 2026
| [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)] | ||
| [System.ObsoleteAttribute("This API supports the .NET Framework infrastructure and is not intended to be used directly from your code.", true)] | ||
| public NetworkChange() { } | ||
| public static bool IsSupported { get { throw null; } } |
Member
There was a problem hiding this comment.
This is a new public API so it will need an API review.
LGTM otherwise
Member
There was a problem hiding this comment.
Could you please open API proposal issue?
Member
Author
There was a problem hiding this comment.
(I can't find the thread but I read feature flag discussion that IsSupported is exempted from API reviews)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #129475 (comment).
cc @bartonjs