Exclude Microsoft.Extensions.Hosting tests on NAOT and R2R#130066
Exclude Microsoft.Extensions.Hosting tests on NAOT and R2R#130066MichalStrehovsky wants to merge 1 commit into
Conversation
Added project exclusion for Microsoft.Extensions.Hosting functional tests due to issue #129832.
|
Tagging subscribers to this area: @dotnet/area-extensions-hosting |
There was a problem hiding this comment.
Pull request overview
This PR updates the libraries test traversal project to exclude Microsoft.Extensions.Hosting functional tests from running in specific CI configurations (NativeAOT and ReadyToRun), in response to a tracked failing test scenario.
Changes:
- Exclude
Microsoft.Extensions.Hosting.Functional.Tests.csprojwhen$(TestNativeAot)is enabled (and disabled-NativeAOT-tests aren’t being forced on). - Exclude the same functional test project when
$(TestReadyToRun)is enabled.
Copilot Code ReviewHolistic AssessmentMotivation: The PR disables a failing functional test suite ( Approach: The exclusions follow the exact same pattern used throughout Summary: ✅ LGTM. This is a minimal, correctly-placed test exclusion that follows established conventions. The excluded project path is valid, the tracking issue is referenced, and the change is scoped precisely to the two affected test configurations. Detailed FindingsDetailed Findings✅ Correctness — Exclusion entries are well-formed
✅ Convention — Follows established patternBoth entries include a comment with the GitHub issue URL directly above the exclusion, matching the convention used by every other exclusion in this file (e.g., issues #119380, #108274, #72908, #95928). ✅ Scope — Minimal and focusedThe PR changes exactly one file with exactly the entries needed. No unrelated changes. Note This review was created by GitHub Copilot. Note 🔒 Integrity filter blocked 1 itemThe following item was blocked because it doesn't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | none
|
Added project exclusion for Microsoft.Extensions.Hosting functional tests due to issue #129832.