Skip to content

Fix C# debug adapter failure in v2.3.2: singleton pattern + mutex error handling #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix C# debug adapter failure in v2.3.2: singleton pattern + mutex error handling #2535

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da93da8
Initial plan
Copilot Jan 6, 2026
4ef6dfd
Initial investigation: Found InstallTrackerSingleton import inconsist…
Copilot Jan 6, 2026
cb21d06
Fix: Export InstallTrackerSingleton from library index to maintain si…
Copilot Jan 6, 2026
52a093a
Fix: Also update SDK extension to use library exports instead of dist…
Copilot Jan 6, 2026
a0c20a9
Fix: Add error handling for mutex failures in markInstallAsInUse
Copilot Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sample/yarn.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vscode-dotnet-runtime-extension/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ import
IIssueContext,
InstallationValidator,
InstallRecord,
InstallTrackerSingleton,
InvalidUninstallRequest,
IUtilityContext,
JsonInstaller,
Expand All @@ -85,7 +86,6 @@ import
WebRequestWorkerSingleton,
WindowDisplayWorker
} from 'vscode-dotnet-runtime-library';
import { InstallTrackerSingleton } from 'vscode-dotnet-runtime-library/dist/Acquisition/InstallTrackerSingleton';
import { dotnetCoreAcquisitionExtensionId } from './DotnetCoreAcquisitionId';
import open = require('open');

Expand Down
40 changes: 0 additions & 40 deletions vscode-dotnet-runtime-extension/yarn.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions vscode-dotnet-runtime-library/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export * from './Acquisition/IJsonInstaller';
export * from './Acquisition/InstallationValidator';
export * from './Acquisition/InstallRecord';
export * from './Acquisition/InstallRecordWithPath';
export * from './Acquisition/InstallTrackerSingleton';
export * from './Acquisition/IVersionResolver';
export * from './Acquisition/JsonInstaller';
export * from './Acquisition/LinuxGlobalInstaller';
Expand Down
4 changes: 2 additions & 2 deletions vscode-dotnet-sdk-extension/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ import
EventBasedError,
ExtensionConfigurationWorker,
formatIssueUrl,
GlobalInstallerResolver,
IAcquisitionWorkerContext,
IDotnetAcquireContext,
IDotnetUninstallContext,
IEventStreamContext,
Expand All @@ -38,8 +40,6 @@ import
} from 'vscode-dotnet-runtime-library';
import open = require('open');

import { GlobalInstallerResolver } from 'vscode-dotnet-runtime-library/dist/Acquisition/GlobalInstallerResolver';
import { IAcquisitionWorkerContext } from 'vscode-dotnet-runtime-library/dist/Acquisition/IAcquisitionWorkerContext';
import { dotnetCoreAcquisitionExtensionId } from './DotnetCoreAcquisitionId';

const packageJson = require('../package.json');
Expand Down