Fix data binding fallback update for uncreated controls#14677
Fix data binding fallback update for uncreated controls#14677abineshPalanisamy wants to merge 4 commits into
Conversation
Fix has been added for the issue.
Added unit test cases for the Fix_Issue_13470
Addressed the review correction for Fix_Issue_13470
…into Fix_Issue_13470
|
@abineshPalanisamy please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
Fixes #13470
Proposed changes
Binding.PushData(bool force)to avoid callingSetPropValue(null)when the binding is inactive and the target component has not yet been created.BindingTestsfor a boundNumericUpDownhosted on an inactiveTabPage, where the target control is not yet created and a shared binding manager pushes updates to all bindings.Root cause
BindingManagerBase.BindingManagerBase.PushData()attempts to push data to all associated bindings.TabPage, the target control may not be created yet.IsBinding == false), butBinding.PushData(bool force)still executes the fallback path and callsSetPropValue(null).0.NumericUpDown.Minimumis set to8, so assigning0toNumericUpDown.ValuecausesArgumentOutOfRangeException.Customer Impact
NumericUpDownis hosted inside an inactive or invisible container, such as an unselectedTabPage.Regression?
Risk
Binding.PushData(bool force).Screenshots
Before
Databinding_Before_fix.mp4
After
Databinding_After_fix.mp4
Test methodology
Reproduced the issue scenario described in the GitHub issue:
TabControlcontains twoTabPageinstances.NumericUpDown.NumericUpDownis placed on an inactive tab page and hasMinimumset to8.NumericUpDowntriggers a binding update through the sharedBindingManagerBase.ArgumentOutOfRangeExceptionbecause the inactive binding path pushes an invalid fallback value to the uncreated target control.Verified that the updated
Binding.PushData(bool force)behavior avoids callingSetPropValue(null)when the target component has not yet been created.Added unit test coverage in
BindingTeststo validate that:NumericUpDownis on an inactive tab;Verified that the existing inactive-binding fallback behavior is preserved when the target component is already created.
Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow