-
Notifications
You must be signed in to change notification settings - Fork 0
test(accuracysnes): C7.06 — Time Over reads set by V = YLOC + 1 #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -156,7 +156,14 @@ ran=0 | |
| # (range evaluation walks OAM two cycles per sprite). RustySNES's per-dot position is anchored to | ||
| # MesenCE on the *line* by scripts/probes/eval-line-213e; the *dot* itself is documentation-anchored | ||
| # only, because the Mesen2 headless runner times out in this environment. Region-independent. | ||
| SNES9X_KNOWN_FAILURES=13 | ||
| # snes9x, +1 test (C7.06 "TimeOver by YLOC+1", fails phase A with code 1): the same scanline-granular | ||
| # sprite model as C7.05, seen from the other side. The row requires Time Over to be clear while the | ||
| # sprites' OWN line is being evaluated (V = 100) and set once the line they paint on has begun | ||
| # (V = 101 = YLOC + 1); snes9x already reads it set on V = 100, i.e. it flags the tile-budget | ||
| # overflow a line early because it evaluates and paints in the same pass. The 20-sprite/8x8 control | ||
| # passes there, so this is the position being wrong, not the budget. Documented by nocash fullsnes | ||
| # and the SNESdev Wiki (34-tile budget, raised by the fetch phase). Region-independent. | ||
| SNES9X_KNOWN_FAILURES=14 | ||
|
Comment on lines
+159
to
+166
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Add a traceable source citation. The known failure is recorded correctly, but the comment only names “fullsnes” and “the SNESdev Wiki.” Add the exact URL and section or page for the 34-tile budget and fetch-phase timing. This lets reviewers distinguish a documented reference divergence from an accidental expected failure. 🤖 Prompt for AI AgentsSource: Path instructions |
||
|
|
||
| # --- snes9x, via the libretro host -------------------------------------------------------------- | ||
| if [[ -f $SNES9X ]]; then | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Remove the unsupported
H = 0precision.The C7.06 test samples
$213Eat an IRQ service point onV = 101. It does not assert that Time Over becomes set atH = 0. The plan explicitly treats(101, 0)as one permitted implementation, not as the measured position.Proposed wording
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Path instructions