fix(location): update ios location implementation to handle thread issues#71
Open
CoryWritesCode wants to merge 1 commit into
Open
fix(location): update ios location implementation to handle thread issues#71CoryWritesCode wants to merge 1 commit into
CoryWritesCode wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been getting a steady stream of EXC_BAD_ACCESS crashes in LocationModuleImpl showing up on _dispatch_worker_thread2. Turns out CLLocationManager is thread-affine — you have to talk to it on the thread you created it on. getCurrentPosition: creates the manager on main, but locationManagerDidChangeAuthorization: was hopping onto a background queue and poking the manager from there. iOS 14+ really doesn't like that.
The original reason for the background hop was fine: +locationServicesEnabled isn't supposed to run on main because it can block. The fix just took too much stuff off-main along for the ride.
Fix