Skip to content

Fix minor code quality issues (AI findings) #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinPayravi merged 1 commit into from
May 13, 2026
Merged

Fix minor code quality issues (AI findings) #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/resources/application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ postgres {
serverName = "localhost"
serverName = ${?POSTGRES_SERVER}
portNumber = "5432"
postNumber = ${?POSTGRES_PORT}
portNumber = ${?POSTGRES_PORT}
databaseName = "dplaapi"
databaseName = ${?POSTGRES_DB}
user = "dplaapi"
Expand Down
2 changes: 1 addition & 1 deletion src/main/scala/dpla/api/v2/search/ElasticSearchResponseHandler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import scala.concurrent.{ExecutionContextExecutor, Future}
import scala.util.{Failure, Success}

/**
* Processes response streams from Elastic Search.
* Processes response streams from Elasticsearch.
*/

sealed trait ElasticSearchResponse
Expand Down
2 changes: 1 addition & 1 deletion src/test/scala/dpla/api/v2/search/paramValidators/ParamValidatorTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ class ParamValidatorTest extends AnyWordSpec with Matchers

"reject too-short param" in {
val given = "d"
val params = Map("sourceResource.subject.name" -> given)
val params = Map("sourceResource.subject.name" -> given)
itemParamValidator ! RawSearchParams(params, replyProbe.ref)
replyProbe.expectMessageType[InvalidSearchParams]
}
Expand Down
Loading