Skip to content

Fix minor code quality issues (AI findings) #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinPayravi merged 2 commits into from
May 9, 2026
Merged

Fix minor code quality issues (AI findings) #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98220cc
Fix minor code quality issues flagged by GitHub AI findings
DominicBM May 8, 2026
794c27d
Link fix
KevinPayravi May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ThumbnailApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class ThumbnailApi {
});

// we only want the cache to have the proxied image from the contributor
// for a short amount because it won't have been sized down
// for a short amount of time because it won't have been sized down
expressResponse.set(this.responseHelper.getCacheHeaders(SHORT_CACHE_TIME));

let remoteImageResponse: Response | undefined;
Expand Down Expand Up @@ -192,7 +192,7 @@ export class ThumbnailApi {
}

private releaseUpstreamBody(response: Response): void {
void response.body?.cancel?.()?.catch(() => {});
void response.body?.cancel().catch((_err: unknown) => void _err);
}

sendError(
Expand Down
Loading