Fix: LoRA checkpoint path consistency when --output is an absolute path#89
Open
voltomoore wants to merge 1 commit into
Open
Fix: LoRA checkpoint path consistency when --output is an absolute path#89voltomoore wants to merge 1 commit into
voltomoore wants to merge 1 commit into
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
draw-things-cli train lorais called with--outputset to an absolute path (e.g.--output /tmp/my-lora), several things go wrong:/tmp/my-lora_500_lora_f32.ckpt), which gets routed throughLoRAZoo.filePathForModelDownloaded()— producing a mangled save path or silent failure.custom_lora.jsonregistry stores the full absolute path as thefilereference, rather than just the filename. This means the Draw Things app cannot resolve the LoRA when looking it up through the model zoo.Changes
resolvedOutputPrefix— Extracted viaURL(fileURLWithPath: output).lastPathComponent, so/tmp/my-lorabecomesmy-lora. Used consistently for all checkpoint naming.Checkpoint save — Uses
resolvedOutputPrefixso the save always goes to a clean basename likemy-lora_500_lora_f32.ckptinside the model zoo directory.Print messages — Now show the actual resolved
outputPathfromLoRAZoo.filePathForModelDownloaded(), so users see the real filesystem path.Final summary — Updated to use the resolved path consistently.
Related
Closes #88.