[#2711] Replaced Admin Toolbar default with the core Navigation module.#2806
Merged
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (29)
📒 Files selected for processing (2)
WalkthroughThe default ChangesDrupal Navigation default
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant ProvisionScript
participant DrupalNavigation
participant NavigationExtraTools
ProvisionScript->>DrupalNavigation: Install navigation
ProvisionScript->>DrupalNavigation: Uninstall toolbar
ProvisionScript->>NavigationExtraTools: Install navigation_extra_tools
NavigationExtraTools-->>ProvisionScript: Complete module setup
Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2806 +/- ##
==========================================
- Coverage 86.77% 86.35% -0.42%
==========================================
Files 98 91 -7
Lines 4778 4624 -154
Branches 47 3 -44
==========================================
- Hits 4146 3993 -153
+ Misses 632 631 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6a5f1c26fe9d529f2e0015b2--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
AlexSkrypnyk
force-pushed
the
feature/2711-navigation
branch
from
July 17, 2026 05:04
d0f95c2 to
f049829
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Enabled the core Navigation module and uninstalled the classic Toolbar during provisioning, shipped 'navigation_extra_tools' for administration shortcuts in place of 'admin_toolbar', and adapted the theme setting to hide the administration navigation.
github-actions
Bot
added
the
CONFLICT
AlexSkrypnyk
force-pushed
the
feature/2711-navigation
branch
from
July 21, 2026 05:50
f049829 to
3d7ce4c
Compare
github-actions
Bot
removed
the
CONFLICT
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/provision-10-example.sh`:
- Around line 52-58: Update the administration setup commands near the
navigation installation to check whether the Toolbar module is installed or
enabled before attempting removal. Skip uninstall when it is absent, but run
drush pm:uninstall toolbar without suppressing errors when present, so
dependency, configuration, and Drush failures abort provisioning and Toolbar
cannot remain alongside Navigation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 170c8832-4b5e-42f2-a38d-deeb18c1b583
⛔ Files ignored due to path filters (29)
.vortex/installer/tests/Fixtures/handler_process/_baseline/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/custom_modules_no_base/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/custom_modules_no_demo/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/custom_modules_no_search/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/custom_modules_none/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/custom_modules_search_without_solr/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_coffee/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_config_split/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_config_update/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_devel/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_environment_indicator/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_navigation_extra_tools/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_pathauto/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_redirect/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_reroute_email/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_robotstxt/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_sdc_devel/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_seckit_shield_stage_file_proxy/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_shield/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_stage_file_proxy/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_no_xmlsitemap/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/modules_none/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/names/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/non_interactive_config_file/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/non_interactive_config_string/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/services_no_clamav/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/services_no_redis/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/services_no_solr/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**.vortex/installer/tests/Fixtures/handler_process/services_none/scripts/provision-10-example.shis excluded by!.vortex/installer/tests/Fixtures/**
📒 Files selected for processing (1)
scripts/provision-10-example.sh
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Code coverage (threshold: 90%) Per-class coverage |
AlexSkrypnyk
added
the
Needs review
github-project-automation
Bot
moved this from In progress
to Release queue
in Vortex 1.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2711
Summary
Vortex now ships the Drupal core
navigationmodule as the default administration UI instead of the classic Toolbar +drupal/admin_toolbarstack, since core Navigation has been stable since Drupal 11.3 and is core's own strategic replacement for Toolbar.The
standardinstall profile still enables coretoolbar, and running Toolbar and Navigation together is a documented conflict that breaks admin contextual links, so provisioning now enablesnavigationand uninstallstoolbar(only when it is actually enabled) rather than just swapping the contrib package.The contrib slot previously held by
drupal/admin_toolbaris now filled bydrupal/navigation_extra_tools, which adds the cache-clear, cron, and database-update shortcuts to the core Navigation sidebar.Changes
composer.json: removeddrupal/admin_toolbar; addeddrupal/navigation_extra_tools(^1.3.2, stable).scripts/provision-10-example.sh: added a dedicated administration-navigation step that runsdrush pm:install navigation, then uninstallstoolbaronly whenmoduleExists('toolbar')is true (so it is a no-op on a re-provision or a navigation-based database, while a genuine uninstall failure still aborts provisioning). Kept independent of the optional-contribMODULESfence since both are core, and swappedadmin_toolbarfornavigation_extra_toolsin the contribpm:installline..vortex/installer/src/Prompts/Handlers/Modules.php: replacedadmin_toolbarwithnavigation_extra_toolsin the installer's selectable module list..vortex/installer/tests/Unit/Handlers/ModulesHandlerDiscoveryTest.phpand.vortex/installer/tests/Functional/Handlers/ModulesHandlerProcessTest.php: updated the discovery and process tests for the module swap, renaming themodules_no_admin_toolbarscenario tomodules_no_navigation_extra_tools.web/themes/custom/your_site_theme/your_site_theme.themeandweb/sites/default/example.settings.local.php: adapted the "hide admin toolbar" dev convenience to hide the Navigation sidebar instead, renaming the settinghide_admin_toolbartohide_admin_navigation..vortex/docs/content/drupal/README.mdxand.vortex/docs/content/drupal/composer-json.mdx: updated the module lists to reflect the swap.modules_no_admin_toolbarfixture), the tooling BATS golden output (.vortex/tooling/tests/unit/provision.bats), and the installer/build/provision demo videos.Upgrade note
Existing sites have
admin_toolbar(and coretoolbar) enabled in their database. Because this change removesdrupal/admin_toolbarfrom the codebase, an existing site must uninstalladmin_toolbarbefore deploying the release that drops it - otherwisedrush deployaborts on the orphaned module (The module admin_toolbar does not exist). The provisioning step here handlestoolbar; the demo database is regenerated without the Admin Toolbar stack so CI provisions cleanly.Screenshots
N/A
Before / After