refactor(design-system)!: remove deprecated DsChip and DsChipGroup components [AR-53409]#341
Open
mmurawski-dn wants to merge 7 commits intodrivenets:nextfrom
Open
Conversation
mmurawski-dn
force-pushed
the
drivenets/michal/AR-53409-remove-ds-chip
branch
from
5dba5c6 to
44ef915
Compare
vpolessky-dn
previously approved these changes
Apr 2, 2026
iromanchuk-dn
previously approved these changes
Apr 7, 2026
StyleShit
requested changes
Apr 9, 2026
Comment on lines
+93
to
+99
| ruleTester.run('no-deprecated-ds-date-input', plugin.rules['no-deprecated-ds-date-input'], { | ||
| valid: ['<DsDatePicker />', '<DsDateRangePicker />'], | ||
|
|
||
| invalid: [ | ||
| { | ||
| code: '<DsChip />', | ||
| errors: [{ message: `DsChip is deprecated. Use DsTag instead.` }], | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| ruleTester.run('no-deprecated-ds-chip-group', plugin.rules['no-deprecated-ds-chip-group'], { | ||
| valid: ['<DsTag />', '<DsTagFilter />'], | ||
|
|
||
| invalid: [ | ||
| { | ||
| code: '<DsChipGroup />', | ||
| errors: [{ message: `DsChipGroup is deprecated. Use DsTagFilter instead.` }], | ||
| code: '<DsDateInput />', | ||
| errors: [{ message: `DsDateInput is deprecated. Use DsDatePicker or DsDateRangePicker instead.` }], |
Member
There was a problem hiding this comment.
I guess this "date-input" diff is because next isn't updated from main?
if so, let's don't merge any PRs to next until we update it from main
Collaborator
Author
There was a problem hiding this comment.
next could have been updated and I would resolve merge conflicts. I think that should be straightforward to fix. @StyleShit do you know maybe can we add the "rebase/merge ff" option to the GH?
Collaborator
Author
There was a problem hiding this comment.
Removed this part, was my accident 👍
mmurawski-dn
dismissed stale reviews from iromanchuk-dn and vpolessky-dn
via
3039410
…ponents [AR-53409]
mmurawski-dn
force-pushed
the
drivenets/michal/AR-53409-remove-ds-chip
branch
2 times, most recently
from
a85ee07 to
dd850d5
Compare
mmurawski-dn
force-pushed
the
drivenets/michal/AR-53409-remove-ds-chip
branch
from
dd850d5 to
1d30c9d
Compare
StyleShit
previously approved these changes
Apr 14, 2026
vpolessky-dn
previously approved these changes
Apr 14, 2026
mmurawski-dn
dismissed stale reviews from vpolessky-dn and StyleShit
via
c14b07e
StyleShit
changed the title
…:mmurawski-dn/design-system into drivenets/michal/AR-53409-remove-ds-chip
mmurawski-dn
force-pushed
the
drivenets/michal/AR-53409-remove-ds-chip
branch
from
84633a3 to
ec7209f
Compare
…ets/michal/AR-53409-remove-ds-chip
mmurawski-dn
force-pushed
the
drivenets/michal/AR-53409-remove-ds-chip
branch
from
ec7209f to
5254586
Compare
iromanchuk-dn
previously approved these changes
Apr 15, 2026
…ets/michal/AR-53409-remove-ds-chip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.