feat(asset): auto-import new asset files on filewatch#392
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds a file-watch decision policy, auto-imports newly discovered asset files, emits ChangesAsset import pipeline
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@OloEngine/src/OloEngine/Asset/AssetManager/EditorAssetManager.cpp`:
- Around line 1226-1230: The immediate SerializeAssetRegistry() call in
EditorAssetManager::OnAssetAdded causes a full registry rewrite for every
auto-imported file, which should be coalesced. Update the registry persistence
path in EditorAssetManager so bulk imports only mark the registry dirty and
flush it once per frame or on a short debounce timer, and ensure the actual disk
write still happens through SerializeAssetRegistry() from a single centralized
flush point.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 6594135e-d19b-431c-abeb-110d7ee0e834
📒 Files selected for processing (12)
OloEditor/src/EditorLayer.cppOloEditor/src/EditorLayer.hOloEditor/src/Panels/ContentBrowserPanel.cppOloEditor/src/Panels/ContentBrowserPanel.hOloEngine/src/OloEngine/Asset/AssetFileWatchPolicy.hOloEngine/src/OloEngine/Asset/AssetManager/EditorAssetManager.cppOloEngine/src/OloEngine/Asset/AssetManager/EditorAssetManager.hOloEngine/src/OloEngine/Core/Events/EditorEvents.hOloEngine/src/OloEngine/Events/Event.hOloEngine/tests/AssetFileWatchPolicyTest.cppOloEngine/tests/AssetLoadedEventTest.cppOloEngine/tests/CMakeLists.txt
Summary by CodeRabbit
New Features
Bug Fixes
Tests