Implement ephemeral sun-direction overrides for lighting iteration#396
Quality Gate passed
Annotations
Check warning on line 1 in OloEngine/tests/MCP/McpRenderOverridesTest.cpp
sonarqubecloud / SonarCloud Code Analysis
Use either // or /* ... */ comments, but do not mix them (see lines 4 and 300).
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVSYko-gJg-z-4sc&open=AZ7_YVSYko-gJg-z-4sc&pullRequest=396
Check warning on line 4399 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
Split this 231 characters long line (which is greater than 230 authorized).
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sQ&open=AZ7_YU79ko-gJg-z-4sQ&pullRequest=396
Check warning on line 408 in OloEditor/src/MCP/McpRenderOverrides.h
sonarqubecloud / SonarCloud Code Analysis
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVK3ko-gJg-z-4sV&open=AZ7_YVK3ko-gJg-z-4sV&pullRequest=396
Check warning on line 363 in OloEditor/src/MCP/McpRenderOverrides.h
sonarqubecloud / SonarCloud Code Analysis
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVK3ko-gJg-z-4sR&open=AZ7_YVK3ko-gJg-z-4sR&pullRequest=396
Check warning on line 2171 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
This lambda has 23 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sL&open=AZ7_YU79ko-gJg-z-4sL&pullRequest=396
Check warning on line 2158 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
using-directive shall not be used.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sJ&open=AZ7_YU79ko-gJg-z-4sJ&pullRequest=396
Check warning on line 2227 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
Remove the redundant return type of this lambda.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sO&open=AZ7_YU79ko-gJg-z-4sO&pullRequest=396
Check warning on line 2199 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
using-directive shall not be used.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sN&open=AZ7_YU79ko-gJg-z-4sN&pullRequest=396
Check warning on line 400 in OloEditor/src/MCP/McpRenderOverrides.h
sonarqubecloud / SonarCloud Code Analysis
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVK3ko-gJg-z-4sU&open=AZ7_YVK3ko-gJg-z-4sU&pullRequest=396
Check warning on line 2227 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
This lambda has 21 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sP&open=AZ7_YU79ko-gJg-z-4sP&pullRequest=396
Check warning on line 610 in OloEngine/src/OloEngine/Renderer/Renderer3D.h
sonarqubecloud / SonarCloud Code Analysis
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVNCko-gJg-z-4sY&open=AZ7_YVNCko-gJg-z-4sY&pullRequest=396
Check warning on line 2117 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
Use the init-statement to declare "scene" inside the if statement.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sG&open=AZ7_YU79ko-gJg-z-4sG&pullRequest=396
Check warning on line 289 in OloEngine/tests/MCP/McpRenderOverridesTest.cpp
sonarqubecloud / SonarCloud Code Analysis
Explicitly declare the size of the array.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVSYko-gJg-z-4se&open=AZ7_YVSYko-gJg-z-4se&pullRequest=396
Check warning on line 2111 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
Make the type of this parameter a reference-to-const. The current type of "server" is "class OloEngine::MCP::McpServer &".
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sH&open=AZ7_YU79ko-gJg-z-4sH&pullRequest=396
Check warning on line 376 in OloEditor/src/MCP/McpRenderOverrides.h
sonarqubecloud / SonarCloud Code Analysis
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVK3ko-gJg-z-4sS&open=AZ7_YVK3ko-gJg-z-4sS&pullRequest=396
Check warning on line 606 in OloEngine/src/OloEngine/Renderer/Renderer3D.h
sonarqubecloud / SonarCloud Code Analysis
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVNCko-gJg-z-4sX&open=AZ7_YVNCko-gJg-z-4sX&pullRequest=396
Check warning on line 430 in OloEditor/src/MCP/McpRenderOverrides.h
sonarqubecloud / SonarCloud Code Analysis
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVK3ko-gJg-z-4sW&open=AZ7_YVK3ko-gJg-z-4sW&pullRequest=396
Check warning on line 2171 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
Remove the redundant return type of this lambda.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sK&open=AZ7_YU79ko-gJg-z-4sK&pullRequest=396
Check warning on line 391 in OloEditor/src/MCP/McpRenderOverrides.h
sonarqubecloud / SonarCloud Code Analysis
Add message to "[[nodiscard]]" attribute explaining why the return value should not be discarded.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVK3ko-gJg-z-4sT&open=AZ7_YVK3ko-gJg-z-4sT&pullRequest=396
Check failure on line 2126 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
End this if...else if construct by an else clause.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sI&open=AZ7_YU79ko-gJg-z-4sI&pullRequest=396
Check warning on line 2197 in OloEditor/src/MCP/McpTools.cpp
sonarqubecloud / SonarCloud Code Analysis
This function has 4 returns, which is more than the 3 allowed.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YU79ko-gJg-z-4sM&open=AZ7_YU79ko-gJg-z-4sM&pullRequest=396
Check warning on line 289 in OloEngine/tests/MCP/McpRenderOverridesTest.cpp
sonarqubecloud / SonarCloud Code Analysis
Use "std::array" or "std::vector" instead of a C-style array.
See more on https://sonarcloud.io/project/issues?id=drsnuggles8_OloEngineBase&issues=AZ7_YVSYko-gJg-z-4sf&open=AZ7_YVSYko-gJg-z-4sf&pullRequest=396